Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14427 +/- ##
============================================
+ Coverage 46.27% 76.54% +30.26%
============================================
Files 1014 176 -838
Lines 87347 10325 -77022
============================================
- Hits 40424 7903 -32521
+ Misses 43898 2241 -41657
+ Partials 3025 181 -2844
Flags with carried forward coverage won't be shown. Click here to find out more. |
JosepBove
requested review from
ajsutton and
mds1
and removed request for
ajsutton
mds1
approved these changes
Feb 19, 2025
mds1
reviewed
Feb 19, 2025
Rjected
pushed a commit
to paradigmxyz/optimism
that referenced
this pull request
Feb 25, 2025
* bump to foundry v1 * library harness failing * rm return name * fix internal revert tests * rerun CI * move to v1 tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare the changes to move to foundry's version 1. @mds1 asked for a benchmark of building and testing, here you have the results on a M3 Max.
After migration:
(this includes the build as I am running just clean between benchmarks)
Before migration:
(this includes the build as I am running just clean between benchmarks)