isthmus: withdrawals-root test in NAT#14353
Closed
protolambda wants to merge 2 commits intodevelopfrom
Closed
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14353 +/- ##
===========================================
- Coverage 45.89% 41.51% -4.39%
===========================================
Files 1007 842 -165
Lines 86310 77012 -9298
===========================================
- Hits 39616 31970 -7646
+ Misses 43701 42227 -1474
+ Partials 2993 2815 -178
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
|
consider this library for easy ABI encoding: https://github.com/lmittmann/w3?tab=readme-ov-file#abi-bindings |
Contributor
Author
emhane
added
H-isthmus
emhane
reviewed
Feb 14, 2025
| priv, err := crypto.HexToECDSA(user.PrivateKey()) | ||
| require.NoError(t, err) | ||
|
|
||
| // construct call input, ugly but no bindings... |
| require.NoError(t, solabi.WriteUint256(&input, big.NewInt(4+20+32+32))) // calldata offset to length data | ||
| require.NoError(t, solabi.WriteUint256(&input, big.NewInt(0))) // length | ||
|
|
||
| // sign a tx to trigger a withdrawal (no ETH value, just a message), submit it |
Contributor
There was a problem hiding this comment.
would like to run this part many times in a loop. is best way to re-run test or can make use of pre-funded wallet more than once here by looping some given number of times (number passed as parameter) ?
This was referenced Feb 20, 2025
Contributor
|
FYI my fixes after rebasing here: #14505 |
Contributor
Author
|
Closing in favor of #14505 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Example isthmus withdrawals-root NAT test, on initial devnet-SDK.
Note: before running this, don't forget to configure Kurtosis with the Isthmus fork
Tests
Additional context
Metadata