op-batcher: prevent SpanChannelOut RLP bytes overflowing MaxRLPBytesPerChannel
#14310
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci authorize 0733746 |
geoknee
reviewed
Feb 13, 2025
|
Hi Geoknee, I had missed performing a fresh compression, which is an important part of the process. |
|
/ci authorize 63cf3d7 |
|
Thanks -- couple of small items outstanding. Are you able to address those? |
|
Sorry, may I know which small outstanding items I missed? |
The unresolved conversations above. One |
|
I am done with the feedback above. |
|
/ci authorize 2ee7a30 |
geoknee
changed the title
SpanChannelOut RLP bytes overflowing MaxRLPBytesPerChannel
geoknee
changed the title
SpanChannelOut RLP bytes overflowing MaxRLPBytesPerChannelSpanChannelOut RLP bytes overflowing MaxRLPBytesPerChannel
geoknee
approved these changes
Feb 14, 2025
Merged
via the queue into
ethereum-optimism:develop
with commit Feb 14, 2025
dcce927
47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that when the channel RLP bytes exceed MaxRLPBytesPerChannel, the batcher does not remove the excess batch. This causes the OP-Node to encounter an error.
msg="failed to read batch from channel reader, skipping to next channel now" err="rlp: value size exceeds available input length"Tests
I added the test
testSpanChannelOut_ExceedMaxRLPBytesPerChannelto ensure that the batcher removes the excess batch when the channel RLP bytes exceed MaxRLPBytesPerChannel.Additional context
Batcher Log
lvl=info msg="Channel closed" input_bytes=10043790 output_bytes=74565 full_reason="channel full: could not take 10043790 bytes as replacement of channel of 9925704 bytes, max is 10000000. err: batch would cause RLP bytes to go over limit" compr_ratio=0.007423990346273668Op-Node Derivation Log
msg="failed to read batch from channel reader, skipping to next channel now" err="rlp: value size exceeds available input length"Metadata