Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-e2e: Move interop action test helpers to a separate package #14204

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Feb 6, 2025

Description

Moves the dsl implementation into a sub-package for interop action tests so it's easier to see the actual tests and so the dsl can choose what is exposed and what is kept internal.

@ajsutton ajsutton requested review from a team as code owners February 6, 2025 03:07
@ajsutton ajsutton requested a review from sebastianst February 6, 2025 03:07
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.93%. Comparing base (af99514) to head (833f50f).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14204       +/-   ##
============================================
+ Coverage    45.72%   66.93%   +21.20%     
============================================
  Files         1006       57      -949     
  Lines        85916     4672    -81244     
============================================
- Hits         39286     3127    -36159     
+ Misses       43647     1376    -42271     
+ Partials      2983      169     -2814     
Flag Coverage Δ
cannon-go-tests-32 62.02% <ø> (-2.02%) ⬇️
cannon-go-tests-64 56.66% <ø> (-1.66%) ⬇️
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 957 files with indirect coverage changes

@ajsutton ajsutton requested a review from Inphi February 6, 2025 03:47
@ajsutton ajsutton added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@mslipper mslipper added this pull request to the merge queue Feb 6, 2025
Merged via the queue into develop with commit 9c3ff66 Feb 6, 2025
46 checks passed
@mslipper mslipper deleted the aj/separate-dsl branch February 6, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants