Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maur/faster upgrade coverage #14191

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Feb 5, 2025

Two changes to speed up code coverage generation in CI:

  1. run only the necessary tests on the upgrade path
  2. use the cache which is used on the test-upgrade job.

@maurelian maurelian requested review from a team as code owners February 5, 2025 21:27
@maurelian maurelian requested a review from refcell February 5, 2025 21:27
@maurelian maurelian force-pushed the maur/faster-upgrade-coverage branch from 262b853 to 2427380 Compare February 5, 2025 21:49
@maurelian maurelian enabled auto-merge February 5, 2025 21:55
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.36%. Comparing base (8cef655) to head (2bc6189).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14191       +/-   ##
============================================
- Coverage    66.93%   46.36%   -20.57%     
============================================
  Files           57      997      +940     
  Lines         4672    84484    +79812     
============================================
+ Hits          3127    39171    +36044     
- Misses        1376    42341    +40965     
- Partials       169     2972     +2803     
Flag Coverage Δ
cannon-go-tests-32 62.02% <ø> (ø)
cannon-go-tests-64 56.66% <ø> (ø)
contracts-bedrock-tests 94.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 940 files with indirect coverage changes

@maurelian maurelian added this pull request to the merge queue Feb 5, 2025
Merged via the queue into develop with commit db62b8f Feb 6, 2025
45 checks passed
@maurelian maurelian deleted the maur/faster-upgrade-coverage branch February 6, 2025 00:15
alcueca pushed a commit that referenced this pull request Feb 7, 2025
* ctb: filter upgrade tests in coverage

* ci: use rpc cache for coverage generation

* undo coverage skip

* ci: fix cache key generation

---------

Co-authored-by: Matthew Slipper <[email protected]>
alcueca pushed a commit that referenced this pull request Feb 7, 2025
* ctb: filter upgrade tests in coverage

* ci: use rpc cache for coverage generation

* undo coverage skip

* ci: fix cache key generation

---------

Co-authored-by: Matthew Slipper <[email protected]>
alcueca pushed a commit that referenced this pull request Feb 7, 2025
* ctb: filter upgrade tests in coverage

* ci: use rpc cache for coverage generation

* undo coverage skip

* ci: fix cache key generation

---------

Co-authored-by: Matthew Slipper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants