op-service/txmgr: fix pending_txs metric
#14168
Merged
+89
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoknee
commented
Feb 5, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14168 +/- ##
===========================================
- Coverage 46.45% 42.16% -4.29%
===========================================
Files 997 832 -165
Lines 84487 75180 -9307
===========================================
- Hits 39246 31702 -7544
+ Misses 42265 40677 -1588
+ Partials 2976 2801 -175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sebastianst
approved these changes
Feb 5, 2025
alcueca
pushed a commit
that referenced
this pull request
Feb 7, 2025
* op-service/txmgr: add TestQueue_Send_MaxPendingMetrics * SendAsync: simplify m.metr.RecordPendingTx() usage * use anonymous fn * tidy
alcueca
pushed a commit
that referenced
this pull request
Feb 7, 2025
* op-service/txmgr: add TestQueue_Send_MaxPendingMetrics * SendAsync: simplify m.metr.RecordPendingTx() usage * use anonymous fn * tidy
alcueca
pushed a commit
that referenced
this pull request
Feb 7, 2025
* op-service/txmgr: add TestQueue_Send_MaxPendingMetrics * SendAsync: simplify m.metr.RecordPendingTx() usage * use anonymous fn * tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14109