Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devnet testing DSL: tx support #14112

Merged
merged 1 commit into from
Feb 18, 2025
Merged

devnet testing DSL: tx support #14112

merged 1 commit into from
Feb 18, 2025

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Feb 3, 2025

Description

This introduces common interfaces and implementations for building
arbitrary transactions, and processing them.

Going forward, this will be helpful to cover the DSL capabilities
needed to validate tx-centric expectations.

The interfaces are very much a work in progress, but they already have
some nice properties, like the fact that they can be implemented in
isolation (the interfaces manipulate only other interfaces and pure
data objects).

Tests

Additional context

Metadata

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.29%. Comparing base (51dc3bd) to head (0b123cd).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14112      +/-   ##
===========================================
- Coverage    45.60%   41.29%   -4.31%     
===========================================
  Files         1006      841     -165     
  Lines        85932    76617    -9315     
===========================================
- Hits         39186    31641    -7545     
+ Misses       43774    42172    -1602     
+ Partials      2972     2804     -168     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 174 files with indirect coverage changes

@sigma sigma force-pushed the sigma/txmgr branch 4 times, most recently from 67ce005 to b8a59ed Compare February 7, 2025 23:08
@sigma sigma changed the base branch from develop to sigma/chainid-type February 7, 2025 23:09
@sigma sigma marked this pull request as ready for review February 7, 2025 23:20
@sigma sigma requested a review from a team as a code owner February 7, 2025 23:20
@sigma sigma requested review from scharissis and removed request for a team February 7, 2025 23:20
Base automatically changed from sigma/chainid-type to develop February 8, 2025 12:09
@sigma
Copy link
Contributor Author

sigma commented Feb 10, 2025

for context: this is part of #14053

This introduces common interfaces and implementations for building
arbitrary transactions, and processing them.

Going forward, this will be helpful to cover the DSL capabilities
needed to validate tx-centric expectations.

The interfaces are very much a work in progress, but they already have
some nice properties, like the fact that they can be implemented in
isolation (the interfaces manipulate only other interfaces and pure
data objects).
@protolambda protolambda added this pull request to the merge queue Feb 18, 2025
Merged via the queue into develop with commit 11b56af Feb 18, 2025
44 checks passed
@protolambda protolambda deleted the sigma/txmgr branch February 18, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants