Skip to content

op-deployer: l1-rpc-url is not needed when deployment-target is genesis #13515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoknee merged 3 commits into from
Mar 6, 2025
Merged

op-deployer: l1-rpc-url is not needed when deployment-target is genesis #13515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
555f17d
l1-rpc-url is only needed when deployment-strategy is live
zhiqiangxu Dec 21, 2024
7cd6dfc
Merge remote-tracking branch 'origin/develop' into check_apply_cli
zhiqiangxu Mar 5, 2025
cd4973e
address comment
zhiqiangxu Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions op-deployer/pkg/deployer/apply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ func (a *ApplyConfig) Check() error {
return fmt.Errorf("logger must be specified")
}

if a.DeploymentTarget == DeploymentTargetGenesis {
if a.L1RPCUrl != "" {
return fmt.Errorf("l1-rpc-url should not be specified when deployment-target is genesis")
}
}

if a.DeploymentTarget == DeploymentTargetLive {
if a.L1RPCUrl == "" {
return fmt.Errorf("l1 RPC URL must be specified for live deployment")
Expand Down
2 changes: 1 addition & 1 deletion op-deployer/pkg/deployer/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ var (
L1RPCURLFlag = &cli.StringFlag{
Name: L1RPCURLFlagName,
Usage: "RPC URL for the L1 chain. Must be set for live chains. " +
"Can be blank for chains deploying to local allocs files.",
"Must be blank for chains deploying to local allocs files.",
EnvVars: []string{
"L1_RPC_URL",
},
Expand Down