contracts-bedrock: interop dep set refactor#13513
Closed
Conversation
Proof of concept refactor on what the dependency set management could look like. The problem is that there is onchain management of the dependency set and the values are kept consistent between L1 and each L2. It is more simple to keep a single source of truth on L1. We will need to move the logic that was previously onchain L2 to the block builder for this to work. There need to be updates done to the `L2ToL2CrossDomainMessenger` as well as the `CrossL2Inbox` for this to be complete, just remove the concept of dep set completely.
opgitgovernance
added
the
S-stale
Contributor
|
This pr has been automatically marked as stale and will be closed in 5 days if no updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proof of concept refactor on what the dependency set management could
look like.
The problem is that there is onchain management of the dependency set
and the values are kept consistent between L1 and each L2. It is more
simple to keep a single source of truth on L1. We will need to move the
logic that was previously onchain L2 to the block builder for this to
work.
There need to be updates done to the
L2ToL2CrossDomainMessengeras well as the
CrossL2Inboxfor this to be complete, just removethe concept of dep set completely.