op-batcher: syncActions is aware of safe=unsafe edge case#13292
Merged
sebastianst merged 10 commits intodevelopfrom Dec 9, 2024
Merged
op-batcher: syncActions is aware of safe=unsafe edge case#13292sebastianst merged 10 commits intodevelopfrom
sebastianst merged 10 commits intodevelopfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13292 +/- ##
============================================
- Coverage 77.73% 42.23% -35.51%
============================================
Files 169 757 +588
Lines 9760 68054 +58294
Branches 849 0 -849
============================================
+ Hits 7587 28743 +21156
- Misses 1957 36919 +34962
- Partials 216 2392 +2176
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sebastianst
reviewed
Dec 9, 2024
and fix behaviour so we don't try to fetch unsafe blocks if there aren't any, even when there are blocks in state
sebastianst
approved these changes
Dec 9, 2024
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
* add additional test case for computeSyncActions * fixup test * check for unsafe = safe edge case & replace oldestUnsafeBlock with nextSafeBlock * add test case for no progress and safe=unsafe * refine log * rename variable * harmonize log ordering and labels * tighten up test behaviour for expectedLogs * add test case: no progress + unsafe=safe + blocks in state and fix behaviour so we don't try to fetch unsafe blocks if there aren't any, even when there are blocks in state * typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #13287 with some more tests and edge case awareness.
Also avoiding use of "oldest unsafe block" in cases where there may not be any unsafe blocks. Preferring "next safe block" instead.