txmgr: Disable default batcher tx send timeout#13284
Merged
sebastianst merged 1 commit intodevelopfrom Dec 6, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13284 +/- ##
============================================
- Coverage 66.77% 42.29% -24.48%
============================================
Files 56 757 +701
Lines 4665 68047 +63382
============================================
+ Hits 3115 28783 +25668
- Misses 1378 36887 +35509
- Partials 172 2377 +2205
Flags with carried forward coverage won't be shown. Click here to find out more.
|
geoknee
approved these changes
Dec 6, 2024
32cc9ca to
efdb016
Compare
efdb016 to
dc3c16a
Compare
tynes
reviewed
Dec 6, 2024
With Holocene, batcher transaction ordering has to be strictly preserved, so trying to send a transaction candidate should just never timeout. Note that the txmgr will still bump fees to get a transaction for the same nonce submitted.
dc3c16a to
fee3aea
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
With Holocene, batcher transaction ordering has to be strictly preserved, so trying to send a transaction candidate should just never timeout. Note that the txmgr will still bump fees to get a transaction for the same nonce submitted.
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
With Holocene, batcher transaction ordering has to be strictly preserved, so trying to send a transaction candidate should just never timeout. Note that the txmgr will still bump fees to get a transaction for the same nonce submitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Holocene, batcher transaction ordering has to be strictly preserved, so trying to send a transaction candidate should just never timeout. Note that the txmgr will still bump fees to get a transaction for the same nonce submitted.