Skip to content

txmgr: Disable default batcher tx send timeout#13284

Merged
sebastianst merged 1 commit intodevelopfrom
seb/disable-batcher-tx-send-timeout
Dec 6, 2024
Merged

txmgr: Disable default batcher tx send timeout#13284
sebastianst merged 1 commit intodevelopfrom
seb/disable-batcher-tx-send-timeout

Conversation

@sebastianst
Copy link
Copy Markdown
Member

With Holocene, batcher transaction ordering has to be strictly preserved, so trying to send a transaction candidate should just never timeout. Note that the txmgr will still bump fees to get a transaction for the same nonce submitted.

@sebastianst sebastianst requested a review from geoknee December 6, 2024 14:44
@sebastianst sebastianst requested a review from a team as a code owner December 6, 2024 14:44
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.29%. Comparing base (bb6f500) to head (fee3aea).
Report is 2 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (bb6f500) and HEAD (fee3aea). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (bb6f500) HEAD (fee3aea)
cannon-go-tests-32 1 0
cannon-go-tests-64 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13284       +/-   ##
============================================
- Coverage    66.77%   42.29%   -24.48%     
============================================
  Files           56      757      +701     
  Lines         4665    68047    +63382     
============================================
+ Hits          3115    28783    +25668     
- Misses        1378    36887    +35509     
- Partials       172     2377     +2205     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-service/txmgr/cli.go 54.29% <ø> (ø)

... and 812 files with indirect coverage changes

@sebastianst sebastianst force-pushed the seb/disable-batcher-tx-send-timeout branch from 32cc9ca to efdb016 Compare December 6, 2024 15:09
@sebastianst sebastianst enabled auto-merge December 6, 2024 15:09
@sebastianst sebastianst force-pushed the seb/disable-batcher-tx-send-timeout branch from efdb016 to dc3c16a Compare December 6, 2024 16:17
With Holocene, batcher transaction ordering has to be strictly preserved, so
trying to send a transaction candidate should just never timeout.
Note that the txmgr will still bump fees to get a transaction for the
same nonce submitted.
@sebastianst sebastianst force-pushed the seb/disable-batcher-tx-send-timeout branch from dc3c16a to fee3aea Compare December 6, 2024 17:09
@sebastianst sebastianst added this pull request to the merge queue Dec 6, 2024
github-merge-queue bot pushed a commit that referenced this pull request Dec 6, 2024
With Holocene, batcher transaction ordering has to be strictly preserved, so
trying to send a transaction candidate should just never timeout.
Note that the txmgr will still bump fees to get a transaction for the
same nonce submitted.
Merged via the queue into develop with commit 354337c Dec 6, 2024
@sebastianst sebastianst deleted the seb/disable-batcher-tx-send-timeout branch December 6, 2024 17:20
sigma pushed a commit that referenced this pull request Dec 19, 2024
With Holocene, batcher transaction ordering has to be strictly preserved, so
trying to send a transaction candidate should just never timeout.
Note that the txmgr will still bump fees to get a transaction for the
same nonce submitted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants