ctb: Fix flake in TestExtractTestNames#13177
Merged
smartcontracts merged 1 commit intodevelopfrom Dec 3, 2024
Merged
Conversation
Golang map iteration order is random, so we need to sort first.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13177 +/- ##
===========================================
- Coverage 44.41% 42.69% -1.73%
===========================================
Files 806 750 -56
Lines 72628 67963 -4665
===========================================
- Hits 32256 29014 -3242
+ Misses 37750 36510 -1240
+ Partials 2622 2439 -183
Flags with carried forward coverage won't be shown. Click here to find out more. |
smartcontracts
approved these changes
Dec 3, 2024
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
Golang map iteration order is random, so we need to sort first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Golang map iteration order is random, so we need to sort first.