add CheckAndDial to avoid duplicate code#13146
Merged
mslipper merged 6 commits intoethereum-optimism:developfrom Dec 6, 2024
Merged
add CheckAndDial to avoid duplicate code#13146mslipper merged 6 commits intoethereum-optimism:developfrom
CheckAndDial to avoid duplicate code#13146mslipper merged 6 commits intoethereum-optimism:developfrom
Conversation
zhiqiangxu
force-pushed
the
add_CheckAndDial
branch
from
71204af to
f6c0c22
Compare
protolambda
reviewed
Dec 6, 2024
Contributor
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
LGTM, just one tiny bugfix. Will apply it and run CI, then ready to approve and merge if the fix looks good to you too.
Contributor
|
Hmm, it looks like the |
Contributor
Author
Conflict is resolved. |
Contributor
|
/ci authorize 079ef70 |
mslipper
approved these changes
Dec 6, 2024
Contributor
|
/ci authorize dd3039e |
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Don't repeat yourself * add a log for loadBlocksIntoState * op-batcher: fix log in batcher/driver.go * modify log --------- Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Matthew Slipper <me@matthewslipper.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts the common code to
CheckAndDialto avoid duplicate code, and slips in a handy log forloadBlocksIntoState.