Skip to content

op-batcher: Fix test flake due to log #13145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoknee merged 1 commit into from
Dec 2, 2024
Merged

op-batcher: Fix test flake due to log #13145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions op-batcher/batcher/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,12 +779,14 @@ func (l *BatchSubmitter) publishToAltDAAndL1(txdata txData, queue *txmgr.Queue[t
if err != nil {
// Don't log context cancelled events because they are expected,
// and can happen after tests complete which causes a panic.
if !errors.Is(err, context.Canceled) {
if errors.Is(err, context.Canceled) {
l.recordFailedDARequest(txdata.ID(), nil)
} else {
l.Log.Error("Failed to post input to Alt DA", "error", err)
// requeue frame if we fail to post to the DA Provider so it can be retried
// note: this assumes that the da server caches requests, otherwise it might lead to resubmissions of the blobs
l.recordFailedDARequest(txdata.ID(), err)
}
// requeue frame if we fail to post to the DA Provider so it can be retried
// note: this assumes that the da server caches requests, otherwise it might lead to resubmissions of the blobs
l.recordFailedDARequest(txdata.ID(), err)
return nil
}
l.Log.Info("Set altda input", "commitment", comm, "tx", txdata.ID())
Expand Down