op-e2e: Expose context in supersystem op-e2e#13135
Merged
protolambda merged 1 commit intodevelopfrom Dec 2, 2024
Merged
Conversation
When any of the setup transactions in `TestInterop_EmitLogs` fail to be mined, the test hangs until it times out. See [here](https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/73118/workflows/b48debaa-55bc-4138-a419-a87c236cbc58/jobs/2994655/artifacts) for an example. This PR updates the SuperSystem API to take a context from the test itself to allow for timeouts.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13135 +/- ##
===========================================
- Coverage 44.39% 42.85% -1.55%
===========================================
Files 799 743 -56
Lines 71840 67175 -4665
===========================================
- Hits 31895 28786 -3109
+ Misses 37352 35965 -1387
+ Partials 2593 2424 -169
Flags with carried forward coverage won't be shown. Click here to find out more. |
protolambda
approved these changes
Dec 2, 2024
sigma
pushed a commit
that referenced
this pull request
Dec 19, 2024
When any of the setup transactions in `TestInterop_EmitLogs` fail to be mined, the test hangs until it times out. See [here](https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/73118/workflows/b48debaa-55bc-4138-a419-a87c236cbc58/jobs/2994655/artifacts) for an example. This PR updates the SuperSystem API to take a context from the test itself to allow for timeouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When any of the setup transactions in
TestInterop_EmitLogsfail to be mined, the test hangs until it times out. See here for an example. This PR updates the SuperSystem API to take a context from the test itself to allow for timeouts.