Skip to content

use CallContract to detect tx failure early if gasLimit is specified #13117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Inphi merged 2 commits into from
Nov 29, 2024
Merged

use CallContract to detect tx failure early if gasLimit is specified #13117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a539aa
use CallContract to detect tx failure early if gasLimit is specified
zhiqiangxu Nov 27, 2024
9c010a7
Merge remote-tracking branch 'origin/develop' into opt_craftTx
zhiqiangxu Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 19 additions & 13 deletions op-service/txmgr/txmgr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,26 +363,32 @@ func (m *SimpleTxManager) craftTx(ctx context.Context, candidate TxCandidate) (*
}
}

// Calculate the intrinsic gas for the transaction
callMsg := ethereum.CallMsg{
From: m.cfg.From,
To: candidate.To,
GasTipCap: gasTipCap,
GasFeeCap: gasFeeCap,
Data: candidate.TxData,
Value: candidate.Value,
}
if len(blobHashes) > 0 {
callMsg.BlobGasFeeCap = blobBaseFee
callMsg.BlobHashes = blobHashes
}
// If the gas limit is set, we can use that as the gas
if gasLimit == 0 {
// Calculate the intrinsic gas for the transaction
callMsg := ethereum.CallMsg{
From: m.cfg.From,
To: candidate.To,
GasTipCap: gasTipCap,
GasFeeCap: gasFeeCap,
Data: candidate.TxData,
Value: candidate.Value,
}
if len(blobHashes) > 0 {
callMsg.BlobGasFeeCap = blobBaseFee
callMsg.BlobHashes = blobHashes
}
gas, err := m.backend.EstimateGas(ctx, callMsg)
if err != nil {
return nil, fmt.Errorf("failed to estimate gas: %w", errutil.TryAddRevertReason(err))
}
gasLimit = gas
} else {
callMsg.Gas = gasLimit
_, err := m.backend.CallContract(ctx, callMsg, nil)
if err != nil {
return nil, fmt.Errorf("failed to call: %w", errutil.TryAddRevertReason(err))
}
}

var txMessage types.TxData
Expand Down