Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-challenger: Allow specifying a chain ID as network. #13027

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ajsutton
Copy link
Contributor

op-program supports custom configs identified by chain ID so make sure op-challenger can pass through a chain ID option even if it isn't a known network.

Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of type-punning chain-ids into --network. It's too late to change now though given that the op-program does it this way.

op-challenger/config/config.go Outdated Show resolved Hide resolved
@ajsutton
Copy link
Contributor Author

We could change op-program as well if we wanted to - this clearly isn't getting much use if it doesn't work in op-challenger yet. I tend to favour this solution as otherwise we need to add a lot more boilerplate code and complexity in deciding what to pass through to challenger etc. I'm open to other ideas though.

op-program supports custom configs identified by chain ID so make sure op-challenger can pass through a chain ID option even if it isn't a known network.
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.73%. Comparing base (980b261) to head (3e5b282).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13027      +/-   ##
===========================================
- Coverage    44.42%   42.73%   -1.70%     
===========================================
  Files          798      742      -56     
  Lines        71680    67017    -4663     
===========================================
- Hits         31846    28639    -3207     
+ Misses       37246    35972    -1274     
+ Partials      2588     2406     -182     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-challenger/config/config.go 95.21% <100.00%> (+0.05%) ⬆️

... and 62 files with indirect coverage changes

Merged via the queue into develop with commit 98a1d92 Nov 26, 2024
45 checks passed
@ajsutton ajsutton deleted the aj/test-custom-config branch November 26, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants