op-deployer: add test for deployConfig overrides#12985
Merged
Conversation
Test hard fork offset overrides
mslipper
approved these changes
Nov 20, 2024
Contributor
mslipper
left a comment
There was a problem hiding this comment.
This is OK for now, but in the future I'd love a more comprehensive test for deploy config overrides since there are many other cases where we need this functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12985 +/- ##
===========================================
- Coverage 68.78% 66.77% -2.02%
===========================================
Files 56 56
Lines 4665 4665
===========================================
- Hits 3209 3115 -94
- Misses 1274 1378 +104
+ Partials 182 172 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test hard fork offset overrides
Description
Tests the input format to override fields in deploy config (hard fork upgrade schedule) and expected output.
Tests
See above.
Additional context
When attempting to use Kurtosis to setup a chain with overrides for L2 hard fork blocks, I wrote this test to figure out how to pass the overrides from here
Metadata
None