op-deployer: add intent-config-type#12970
Merged
Conversation
a7d91eb to
9d0e556
Compare
bitwiseguy
commented
Nov 22, 2024
bitwiseguy
commented
Nov 22, 2024
mslipper
suggested changes
Nov 22, 2024
Contributor
mslipper
left a comment
There was a problem hiding this comment.
A few issues I'd like to address before merge. Happy to pair next week to resolve them.
mslipper
reviewed
Nov 26, 2024
mslipper
approved these changes
Nov 27, 2024
fc440e4 to
3af7850
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12970 +/- ##
===========================================
- Coverage 44.46% 42.81% -1.66%
===========================================
Files 798 743 -55
Lines 71682 67175 -4507
===========================================
- Hits 31876 28762 -3114
+ Misses 37219 35990 -1229
+ Partials 2587 2423 -164
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates the concept of
intent-config-type. Based on the selection, some fields are auto-populated and others are expected to be populated by the user prior to runningop-deployer apply. Valid options are:testused by current test suite, deterministically generates addresses/keys used in testingstandard(default, uses standard values as defined in superchain-registry where possible)customrequires all params to be populated by user, errors duringapplyif any don't get setstrictsame as "standard", but sets additional paramsstandard-overridesstrict-overridesDesign Details
op-deployer initintent.SetInitValues: generates initial intent (with many empty fields)op-deployer applyop-deployer applyinitintent.ValidateIntentConfigType: validates that all fields have been populated, and that values meet expectation (e.g. standard values are used ifintent-config-type=standardOpen questions
Which fields should the
standard-overrides/strict-overridessettings allow to be overridden? The way this is currently implemented:standard-overrides:op-deployer init: sets intent.toml standard valuesop-deployer apply: validates that all values are populated (i.e. non zero value) but doesn't require specific valuesstrict-overrides:op-deployer init: sets intent.toml strict valuesop-deployer apply: validates that all values are populated (i.e. non zero value) but doesn't require specific valuesMeta
Closes https://github.com/ethereum-optimism/platforms-team/issues/305