contracts: remove op-nft

[tynes]

Description

Remove the op-nft package from the contracts package. None of these
contracts are maintained and can be moved to another repo if necessary.
The purpose of this commit is to reduce compilation time. Less files
to compile means less compilation time.

[blmalone]

nice, lgtm!

[tynes]

Hey @smartcontracts, looks like we hit an edge case in the bash script for the heavy fuzz CI job

#!/bin/bash -eo pipefail
TEST_FILES=$(git diff origin/develop...HEAD --name-only -- './test/**/*.t.sol' | sed 's|packages/contracts-bedrock/||')
TEST_FILES=$(echo "$TEST_FILES" | circleci tests split --split-by=timings)
TEST_FILES=$(echo "$TEST_FILES" | sed 's|^test/||')
MATCH_PATH="./test/{$(echo "$TEST_FILES" | paste -sd "," -)}"
forge test --match-path "$MATCH_PATH"

Error reading historical timing data: file does not exist
Requested weighting by historical based timing, but they are not present. Falling back to weighting by name.
No tests match the provided pattern:
        match-path: `./test/{periphery/op-nft/AttestationStation.t.sol,periphery/op-nft/Optimist.t.sol,periphery/op-nft/OptimistAllowlist.t.sol,periphery/op-nft/OptimistInviter.t.sol}`
Error: 
No tests to run

Exited with code exit status 1

When a file is deleted, we need to be able to handle that case. Perhaps filter out before passing to foundry?

[smartcontracts]

Hey @smartcontracts, looks like we hit an edge case in the bash script for the heavy fuzz CI job

#!/bin/bash -eo pipefail
TEST_FILES=$(git diff origin/develop...HEAD --name-only -- './test/**/*.t.sol' | sed 's|packages/contracts-bedrock/||')
TEST_FILES=$(echo "$TEST_FILES" | circleci tests split --split-by=timings)
TEST_FILES=$(echo "$TEST_FILES" | sed 's|^test/||')
MATCH_PATH="./test/{$(echo "$TEST_FILES" | paste -sd "," -)}"
forge test --match-path "$MATCH_PATH"

Error reading historical timing data: file does not exist
Requested weighting by historical based timing, but they are not present. Falling back to weighting by name.
No tests match the provided pattern:
        match-path: `./test/{periphery/op-nft/AttestationStation.t.sol,periphery/op-nft/Optimist.t.sol,periphery/op-nft/OptimistAllowlist.t.sol,periphery/op-nft/OptimistInviter.t.sol}`
Error: 
No tests to run

Exited with code exit status 1

When a file is deleted, we need to be able to handle that case. Perhaps filter out before passing to foundry?

Good catch, thanks, I can open a PR tomorrow to filter out removed files

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (bc6f8de) to head (4d04c3a).
Report is 35 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #12950      +/-   ##
===========================================
- Coverage    68.78%   66.77%   -2.02%     
===========================================
  Files           56       56              
  Lines         4665     4665              
===========================================
- Hits          3209     3115      -94     
- Misses        1274     1378     +104     
+ Partials       182      172      -10     

Flag	Coverage Δ
cannon-go-tests-32	61.85% <ø> (-2.02%)	⬇️
cannon-go-tests-64	56.72% <ø> (-1.66%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles