Skip to content

Typo Update pr-guidelines.md#12929

Merged
smartcontracts merged 1 commit intoethereum-optimism:developfrom
defitricks:patch-1
Nov 19, 2024
Merged

Typo Update pr-guidelines.md#12929
smartcontracts merged 1 commit intoethereum-optimism:developfrom
defitricks:patch-1

Conversation

@defitricks
Copy link
Contributor

Description:

This PR fixes a typo in the merge requirements section of the PR guidelines. Specifically, the phrase "CI must passing" has been corrected to "CI must pass".

Issue:

  • The original phrase "CI must passing" is incorrect because after the modal verb "must", the main verb should be used in its base form (i.e., "pass"). "Passing" is a present participle, which does not fit grammatically in this context.

Importance:

  • Correcting this typo is important for clarity and accuracy. Using the correct grammatical structure ensures that the guidelines are clear and understandable for all contributors. Additionally, it helps maintain the professional quality of the documentation.

Please review and approve the change.

CI must passing should be CI must pass.
@defitricks defitricks requested a review from a team as a code owner November 14, 2024 16:13
@defitricks defitricks requested a review from mbaxter November 14, 2024 16:13
@smartcontracts
Copy link
Contributor

/ci authorize 952286a

@smartcontracts
Copy link
Contributor

Thanks!

@smartcontracts smartcontracts added this pull request to the merge queue Nov 19, 2024
Merged via the queue into ethereum-optimism:develop with commit d675309 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants