Conversation
sigma
force-pushed
the
sigma/just-migration
branch
5 times, most recently
from
dc23e03 to
bb1f7fd
Compare
|
Note: this is mostly a POC / RFC at this point. If there's buy-in, we can start migrating targets more seriously. |
sigma
force-pushed
the
sigma/just-migration
branch
2 times, most recently
from
e3d45b9 to
4e71f61
Compare
sigma
force-pushed
the
sigma/just-migration
branch
5 times, most recently
from
d9058c4 to
9d11933
Compare
sigma
force-pushed
the
sigma/just-migration
branch
5 times, most recently
from
3df1cf6 to
81b2ace
Compare
|
This is sick! |
mslipper
left a comment
mslipper
left a comment
There was a problem hiding this comment.
LGTM. Really glad we're deprecating Make. What's the plan to communicate this, roll it out, and completely deprecate Make?
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
Nice work on the just utils 👍
If we create draft PRs for docs updates, then I think we can migrate a service and merge the docs PR around the same time. The just/deprecated.mk is already very helpful.
|
I've thought of some issue: command-line variables for the make invocation are not passed properly to just right now, which is problematic and might disrupt some workflows. Let me take a stab at sanitizing MAKEFLAGS and injecting the result into the just invocation |
sigma
force-pushed
the
sigma/just-migration
branch
from
81b2ace to
7ec79ca
Compare
A lot of our build recipes share similar structures. Move some of these to modules so we can control them centrally.
This allows us to implement deprecated Makefiles as: DEPRECATED_TARGETS := ... include ../just/deprecate.mk
We need to make sure our build framework is included in the docker build context. Also make sure just is part of the builder image.
sigma
force-pushed
the
sigma/just-migration
branch
from
7ec79ca to
470c28d
Compare
Alright, this is now fixed (and was indeed causing divergence of behavior in CircleCI) |
4 participants
Description
This change proposes a migration path from current Makefile to future
justfile.
It introduces common modules for just recipes, an include file for
newly-converted Makefiles, and an example of usage for op-batcher.
This enables a smooth transition, keeping "make" working (but
advertising the new workflow) as long as we need it to while
introducing just wherever convenient.
Metadata