feat(ctb): Holocene upgrade package#12878
Merged
Conversation
ajsutton
reviewed
Nov 8, 2024
packages/contracts-bedrock/scripts/upgrades/holocene/templates/bundle_template.json
Outdated
Show resolved
Hide resolved
clabby
force-pushed
the
cl/holocene-upgrade-package
branch
from
3fc18b4 to
59f5c00
Compare
clabby
commented
Nov 8, 2024
packages/contracts-bedrock/scripts/upgrades/holocene/DeployUpgrade.s.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/upgrades/holocene/DeployUpgrade.s.sol
Outdated
Show resolved
Hide resolved
clabby
force-pushed
the
cl/holocene-upgrade-package
branch
from
4ec0120 to
4e89f6a
Compare
clabby
commented
Nov 8, 2024
clabby
commented
Nov 8, 2024
ajsutton
reviewed
Nov 8, 2024
Contributor
ajsutton
left a comment
ajsutton
left a comment
There was a problem hiding this comment.
This looks right for chains that use permissionless fault proofs but will introduce security issues for chains that are permissioned only currently because it calls setImplementation for the permissionless game type.
packages/contracts-bedrock/scripts/upgrades/holocene/.env.example
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/upgrades/holocene/DeployUpgrade.s.sol
Outdated
Show resolved
Hide resolved
packages/contracts-bedrock/scripts/upgrades/holocene/templates/bundle_template.json
Outdated
Show resolved
Hide resolved
ajsutton
approved these changes
Nov 12, 2024
Contributor
ajsutton
left a comment
ajsutton
left a comment
There was a problem hiding this comment.
This LGTM. I think we will just need to document how to set the required absolute prestate - it won't be in the contracts release for every chain that uses this because they may only be activating holocene after op-mainnet and the release will already have been finalized by then.
mds1
reviewed
Nov 13, 2024
mds1
reviewed
Nov 13, 2024
packages/contracts-bedrock/scripts/upgrades/holocene/templates/sc-ops-task/README.md
Outdated
Show resolved
Hide resolved
mds1
reviewed
Nov 13, 2024
packages/contracts-bedrock/scripts/upgrades/holocene/templates/sc-ops-task/README.md
Outdated
Show resolved
Hide resolved
mds1
reviewed
Nov 13, 2024
mds1
reviewed
Nov 13, 2024
mds1
reviewed
Nov 13, 2024
packages/contracts-bedrock/scripts/upgrades/holocene/DeployUpgrade.s.sol
Show resolved
Hide resolved
mds1
reviewed
Nov 13, 2024
packages/contracts-bedrock/scripts/upgrades/holocene/templates/bundle_template.json
Outdated
Show resolved
Hide resolved
mds1
reviewed
Nov 13, 2024
packages/contracts-bedrock/scripts/upgrades/holocene/templates/bundle_template.json
Outdated
Show resolved
Hide resolved
clabby
force-pushed
the
cl/holocene-upgrade-package
branch
from
7decda6 to
d82e28d
Compare
mds1
approved these changes
Nov 13, 2024
clabby
added a commit
that referenced
this pull request
Nov 17, 2024
* feat(ctb): Holocene upgrade package * lint * lint * add example env to sc-ops task * fix * reuse `SystemConfig` and `MIPS` impls optionally * optionally deploy a new `DelayedWETH` proxy + impl add check * env lint * add docker image to docker tag service * kelvin idiot-proofing ask * fetch standard config addresses for Holocene * lint * ajsutton review: Deploy separate DelayedWETH proxies for the FDG/PDG * ajsutton review: Conditional FDG usage * use contracts rc tag * mds review * split `SystemConfig` and proofs contracts upgrades * add option to completely disclude the fault proof contracts fix * Update README * verify * deploy config * fix contract tag * README update * semgrep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds a holocene upgrade package to the
contracts-bedrockscripts.This docker image can be used to:
SystemConfigandMIPSimplementations.DelayedWETHimplementation, for use in the newDelayedWETHproxies for the dispute games.PermissionedDisputeGameand accompanyingDelayedWETHproxy.FaultDisputeGameand accompanyingDelayedWETHproxy.superchain-opstask.Usage
See
README.mdin the package directory.