Conversation
axelKingsley
left a comment
There was a problem hiding this comment.
Looking good so far
fab81fb to
ca4411b
Compare
|
Extended the draft, ready for review now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12819 +/- ##
===========================================
- Coverage 44.51% 42.77% -1.74%
===========================================
Files 801 745 -56
Lines 72026 67361 -4665
===========================================
- Hits 32059 28813 -3246
+ Misses 37359 36120 -1239
+ Partials 2608 2428 -180
Flags with carried forward coverage won't be shown. Click here to find out more. |
ghost
left a comment
There was a problem hiding this comment.
I think this is comprehensive and can't think of anything else rn that we should add. I think the "About Safety" section could be a little more clear about the progression through the states. Maybe by using a list for the new flow, like the existing states are listed. But the diagram helps there so it may not be necessary.
Other than that it's clear to me and seems to be sufficient for explaining and using op-supervisor.
|
Going to merge this: better than not having a config. We'll do another iteration of the wording and control flow once the recent data-flow PRs are all merged into develop. |
* op-supervisor: readme draft * op-supervisor: fix review suggestions * op-supervisor: readme extension * op-supervisor: fix mermaid diagram syntax
Description
A readme for the op-supervisor. Starting with a technical overview of the interactions and composition of the op-supervisor.
Fix #12967