Skip to content

op-supervisor: readme#12819

Merged
protolambda merged 4 commits intodevelopfrom
supervisor-readme
Dec 6, 2024
Merged

op-supervisor: readme#12819
protolambda merged 4 commits intodevelopfrom
supervisor-readme

Conversation

@protolambda
Copy link
Copy Markdown
Contributor

@protolambda protolambda commented Nov 5, 2024

Description

A readme for the op-supervisor. Starting with a technical overview of the interactions and composition of the op-supervisor.

Fix #12967

Copy link
Copy Markdown
Contributor

@axelKingsley axelKingsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far

@protolambda protolambda marked this pull request as ready for review November 6, 2024 05:30
@protolambda protolambda added this to the Interop: Stable Devnet milestone Nov 25, 2024
@protolambda
Copy link
Copy Markdown
Contributor Author

Extended the draft, ready for review now

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.77%. Comparing base (4ee839a) to head (9a8dd61).
Report is 87 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12819      +/-   ##
===========================================
- Coverage    44.51%   42.77%   -1.74%     
===========================================
  Files          801      745      -56     
  Lines        72026    67361    -4665     
===========================================
- Hits         32059    28813    -3246     
+ Misses       37359    36120    -1239     
+ Partials      2608     2428     -180     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 65 files with indirect coverage changes

@protolambda protolambda requested review from a user and axelKingsley December 4, 2024 14:43
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is comprehensive and can't think of anything else rn that we should add. I think the "About Safety" section could be a little more clear about the progression through the states. Maybe by using a list for the new flow, like the existing states are listed. But the diagram helps there so it may not be necessary.

Other than that it's clear to me and seems to be sufficient for explaining and using op-supervisor.

@protolambda
Copy link
Copy Markdown
Contributor Author

Going to merge this: better than not having a config. We'll do another iteration of the wording and control flow once the recent data-flow PRs are all merged into develop.

@protolambda protolambda added this pull request to the merge queue Dec 6, 2024
Merged via the queue into develop with commit 17511a2 Dec 6, 2024
@protolambda protolambda deleted the supervisor-readme branch December 6, 2024 19:31
sigma pushed a commit that referenced this pull request Dec 19, 2024
* op-supervisor: readme draft

* op-supervisor: fix review suggestions

* op-supervisor: readme extension

* op-supervisor: fix mermaid diagram syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add READMEs to Important Packages

2 participants