cannon: Add more concurrency primitives tests #12771
Merged
mbaxter merged 6 commits intoethereum-optimism:developfrom Nov 18, 2024
Merged
cannon: Add more concurrency primitives tests #12771mbaxter merged 6 commits intoethereum-optimism:developfrom
mbaxter merged 6 commits intoethereum-optimism:developfrom
Conversation
Contributor
Author
|
Why CI show |
Contributor
Due to recent changes in CI, a team member that is part of the github org needs to authorize each PR for security purposes |
Contributor
|
/ci authorize 40f5ccc |
Contributor
Author
|
Does it need auth again? |
Contributor
|
/ci authorize 5acf609 |
mbaxter
reviewed
Nov 4, 2024
mbaxter
reviewed
Nov 8, 2024
Contributor
|
/ci authorize 146061e |
mbaxter
approved these changes
Nov 15, 2024
Contributor
mbaxter
left a comment
mbaxter
left a comment
There was a problem hiding this comment.
@GrapeBaBa - this looks good to me! I just left a few additional nits - if you could respond to the remaining open comments, I can merge when those are resolved.
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
GrapeBaBa
force-pushed
the
moresynctests
branch
from
146061e to
f121952
Compare
Contributor
|
/ci authorize f121952 |
mbaxter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR add more Go concurrency primitives for testing MT-Cannon
Tests
Additional context
Metadata