Skip to content

op-deployer: error handling bugs #12507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mslipper merged 2 commits into from
Oct 17, 2024
Merged

op-deployer: error handling bugs #12507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ba6205
op-deployer: error handling bugs
blmalone Oct 17, 2024
c600c4e
fix: less requests to node to get latest block.
blmalone Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions op-deployer/pkg/deployer/pipeline/opchain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@ func DeployOPChain(ctx context.Context, env *Env, bundle ArtifactsBundle, intent
DelayedWETHPermissionlessGameProxyAddress: dco.DelayedWETHPermissionlessGameProxy,
})

currentBlock, _ := env.L1Client.BlockNumber(ctx)
block, _ := env.L1Client.BlockByNumber(ctx, big.NewInt(int64(currentBlock)))
block, err := env.L1Client.BlockByNumber(ctx, nil)
if err != nil {
return fmt.Errorf("failed to get latest block by number: %w", err)
}
currentBlockHash := block.Hash()

errCh := make(chan error, 8)
Expand Down Expand Up @@ -137,7 +139,7 @@ func DeployOPChain(ctx context.Context, env *Env, bundle ArtifactsBundle, intent
var lastTaskErr error
for i := 0; i < len(setImplementationAddressTasks); i++ {
taskErr := <-errCh
if lastTaskErr != nil {
if taskErr != nil {
lastTaskErr = taskErr
}
}
Expand Down