Holocene: SystemConfig contract changes for updating EIP-1559 params#12498
Merged
Holocene: SystemConfig contract changes for updating EIP-1559 params#12498
Conversation
roberto-bayardo
force-pushed
the
holocene-1559
branch
from
75dd66a to
15ae54a
Compare
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
2 times, most recently
from
88bcf36 to
109410a
Compare
tynes
reviewed
Oct 17, 2024
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
from
109410a to
ffa6ccd
Compare
tynes
approved these changes
Oct 17, 2024
roberto-bayardo
force-pushed
the
holocene-1559
branch
12 times, most recently
from
fdab9b0 to
997654a
Compare
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
from
2dcd14b to
fe4bc23
Compare
roberto-bayardo
force-pushed
the
holocene-1559
branch
from
997654a to
a2526df
Compare
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
from
fe4bc23 to
4ff0f2e
Compare
sebastianst
force-pushed
the
holocene-1559
branch
from
a2526df to
fdab9b0
Compare
roberto-bayardo
force-pushed
the
holocene-1559
branch
4 times, most recently
from
b1e6342 to
4af2171
Compare
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
from
4ff0f2e to
f9c302f
Compare
roberto-bayardo
force-pushed
the
holocene-1559
branch
3 times, most recently
from
7deea46 to
4ff4d65
Compare
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
from
f9c302f to
81935eb
Compare
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
roberto-bayardo
force-pushed
the
holocene-sysconfig
branch
2 times, most recently
from
3b08777 to
a1c2546
Compare
tynes
force-pushed
the
holocene-sysconfig
branch
from
a1c2546 to
eb6461c
Compare
Contributor
|
Semgrep found 1 require() must include a reason string Ignore this finding from sol-style-require-reason.Semgrep found 5
Inputs to functions must be prepended with an underscore ( |
tynes
approved these changes
Oct 22, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…thereum-optimism#12498) * eip-1559 sysconfig contract changes * tests: add SystemConfig tests --------- Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extends the SystemConfig contract with the new getters and setters for configuring the EIP-1559 parameters.
Tests
Additional context
Metadata