Skip to content

op-e2e: Increase sequencer window for fault proof tests.#12479

Merged
Inphi merged 1 commit intodevelopfrom
aj/increase-sequencer-window
Oct 16, 2024
Merged

op-e2e: Increase sequencer window for fault proof tests.#12479
Inphi merged 1 commit intodevelopfrom
aj/increase-sequencer-window

Conversation

@ajsutton
Copy link
Contributor

Description

Reduces flakiness by giving the batcher more time to produce batches.

Reduces flakiness by giving the batcher more time to produce batches.
@ajsutton ajsutton requested a review from Inphi October 16, 2024 04:23
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this.
I'm curious what recently changed that broke the tests.

@Inphi Inphi added this pull request to the merge queue Oct 16, 2024
Merged via the queue into develop with commit c93c972 Oct 16, 2024
@Inphi Inphi deleted the aj/increase-sequencer-window branch October 16, 2024 06:29
@ajsutton
Copy link
Contributor Author

We changed over to using self-hosted runners so the performance of the box changed. Overall it's faster, but the box is under much higher load since its running all tests on the same box so you get periodic spikes where things take unusually long. The same thing happened from time to time in the CircleCI runners to, it just shifts around how often it happens in different places.

samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
…timism#12479)

Reduces flakiness by giving the batcher more time to produce batches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants