feat: Move checkOutput from DeployOPChainOutput to DeployOPChain script#12469
Merged
feat: Move checkOutput from DeployOPChainOutput to DeployOPChain script#12469
Conversation
Contributor
|
Semgrep found 6
Inputs to functions must be prepended with an underscore ( Semgrep found 1 No Semgrep found 1 Do not use Semgrep found 1 MarshalJSON with a pointer receiver has surprising results: golang/go#22967 Ignore this finding from marshal-json-pointer-receiver.Semgrep found 1 superfluous nil err check before return Ignore this finding from err-nil-check. |
fc3de7a to
135f97f
Compare
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…pt (ethereum-optimism#12469) * feat: Move checkOutput from DeployOPChainOutput to DeployOPChain script * fix: Fix compiler warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves
checkOutput()andassertValidDeploy()and all other similarassertX()functions fromDeployOPChainOutputtoDeployOPChain, as the I/O contracts should be kept as simple as possible.The amount of code which is moved makes the diff confusing to read. The actual changes are limited to:
DeployOutput _dooargument to each assert function_doo(ie.opChainProxyAdmin()becomes_doo.opChainProxyAdmin().