fix: Allow reading the initialized slot of a Proxy#12465
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maurelian and the rest of your teammates on |
maurelian
requested review from
Inphi and
mds1
and removed request for
a team and
Inphi
tynes
reviewed
Oct 15, 2024
maurelian
force-pushed
the
load-init-fix-2
branch
3 times, most recently
from
dfc9683 to
1d1edb9
Compare
tynes
approved these changes
Oct 15, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…#12465) * fix: Allow reading the initialized slot of a Proxy * fix: unused imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12422
I spoke with @tynes who had initially written the logic, and he also felt that it was a bug to prevent reading the Proxy's initialized slot.