op-supervisor: dependency-set config#12450
Merged
axelKingsley merged 3 commits intodevelopfrom Oct 15, 2024
Merged
Conversation
Contributor
|
Semgrep found 3
require() must include a reason string Ignore this finding from sol-style-require-reason.Semgrep found 2 No |
Contributor
|
Semgrep found 15
TODO in error handling code Ignore this finding from err-todo. |
bef1185 to
962730f
Compare
49a58ab to
320d742
Compare
962730f to
e7fb182
Compare
320d742 to
0cc2e9a
Compare
Contributor
|
This code was reviewed synchronously with @axelKingsley , @tyler-smith and @protolambda |
axelKingsley
approved these changes
Oct 15, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* op-supervisor: cleanup, refactor to take local-safe info from op-node * op-supervisor: dependency-set config --------- Co-authored-by: axelKingsley <axel.kingsley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #12427
Introduces
depsetpackage:DependencySetSource: to define how the below configuration can be sourced.DependenySet: to define what chain can execute and initiate at what time.StaticConfigDependencySet: to define the set as a static map of chains.JsonDependencySetLoader: to define the set as the above static map, loaded from a json file.We may introduce more dynamic dependency sets, but this is sufficient for testing / devnets for now.
The idea is that a set could sync in the background, and return errors on timestamp queries that it hasn't synced yet.
The op-supervisor CLI flags have been extended with a
--dependency-setto point to a JSON file that the set can then be loaded from.Tests
Additional context
In a follow-up we should add dependency-set chain-ID iteration or something, so we can initialize the right services, before a chain-monitor is known.