Conversation
Contributor
|
Semgrep found 3
require() must include a reason string Ignore this finding from sol-style-require-reason.Semgrep found 2 No |
ghost
reviewed
Oct 14, 2024
49a58ab to
320d742
Compare
4c52936 to
b6e34b9
Compare
320d742 to
0cc2e9a
Compare
axelKingsley
approved these changes
Oct 15, 2024
Contributor
axelKingsley
left a comment
There was a problem hiding this comment.
Reviewed offline, and then again synchronously with @protolambda . I addressed the minor bits I saw myself.
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* op-supervisor: cleanup, refactor to take local-safe info from op-node * interop: draft fromda DB * op-supervisor: fromda DB fixes and tests * fix test warnings * add extra check ; remove LatestDerived, LatestDerivedFrom --------- Co-authored-by: axelKingsley <axel.kingsley@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Depends on #12427
Simplified from-da DB, that always encodes both the L1 and L2 block as part of the same entry.
For a year of data, at 1 second block time, 100 bytes per entry, that would be
365 * 24 * 60 * 60 * 100 = 3,153,600,000, or about 3 GB. And with the single-type fixed-width append-only entries, it should be robust against corruption on restart, and easily sliced/diced/shared.This generalized the entry-DB with generics such that we can use a custom entry type, and customize the entry size.
Tests
Additional context
Supersedes draft 1 from here: #12428
and prior entry-db generalization work.
Metadata
Fix #12076