op-supervisor: safety index (work in progress) #12387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes from Axel: - Wire in APIs for new input flow - Better logging for Iterator State Needs - Remove Chain Monitor ; Trigger Chain Processor on Local Unsafe Update - BlockRef - uncomment skipped guard Work in progress by Proto: - op-supervisor: generic entry type - experimental - op-supervisor: progresss on generic entry db, and derived-from DB
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
Comment on lines
97
to
101
| if err != nil { | ||
| return common.Hash{}, err | ||
| } | ||
| // TODO(#11693): need to get the actual block hash for this log entry for reorg detection | ||
| return common.Hash{}, nil |
Contributor
There was a problem hiding this comment.
Comment on lines
97
to
100
| if err != nil { | ||
| return err | ||
| } | ||
| return nil |
Contributor
There was a problem hiding this comment.
Comment on lines
+98
to
+102
| if err != nil { | ||
| return eth.BlockID{}, err | ||
| } | ||
| // TODO fix this for cross-safe to work | ||
| return eth.BlockID{}, nil |
Contributor
There was a problem hiding this comment.
| finalizedL1 := db.finalizedL1 | ||
| derived, err := db.LastDerivedFrom(chainID, finalizedL1.ID()) | ||
| if err != nil { | ||
| return eth.BlockID{}, fmt.Errorf("could not find what was last derived from the finalized L1 block") |
Contributor
There was a problem hiding this comment.
No fmt.Errorf invocations without fmt arguments allowed
| // The L2 blockhash ensures we are still checking the same log content. | ||
| crossDerivedFrom, err := s.deps.CrossDerivedFrom(chainID, includedIn, execMsg.LogIdx) | ||
| if err != nil { | ||
| // TODO this can be ErrFuture when we don't know the cross-derivation link of the L2 block yet. |
Contributor
There was a problem hiding this comment.
| // does indeed exist in an L2 block. | ||
| includedIn, err := s.deps.Check(chainID, execMsg.BlockNum, execMsg.LogIdx, execMsg.Hash) | ||
| if err != nil { | ||
| // TODO this can be an ErrFuture where we just don't have the data for a definite answer, |
Contributor
There was a problem hiding this comment.
Contributor
Author
|
Closing in favor of #12427 And will open a separate PR for the derived-from DB, and another separate PR for the cross-safe update process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from Axel, rebased on develop (from #12213 ):
Work in progress by Proto:
Description
Draft PR, to track changes.
Plan to land the changes:
entrydb, including the naming / usages tweaks in the event logs index.fromdafromdatype of index, to handle the safety index functionalityTests
Work in progress
Additional context
Metadata