feat(op-batcher): wait for pre-genesis RPC request loop

[jsvisa]

Description

closes #11630

Tests

Additional context

Metadata

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (fb62380) to head (d8dcfc5).
Report is 57 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #12383      +/-   ##
===========================================
- Coverage    64.32%   64.14%   -0.19%     
===========================================
  Files           52       52              
  Lines         4348     4348              
===========================================
- Hits          2797     2789       -8     
- Misses        1376     1385       +9     
+ Partials       175      174       -1     

Flag	Coverage Δ
cannon-go-tests	64.14% <ø> (-0.19%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

[jsvisa]

@protolambda PTAL

[tynes]

Thank you for the PR @jsvisa !

[protolambda]

Looks good! Thank you for implementing this change. Two small nits, then happy to merge. In terms of testing I think it's covered well enough in op-e2e, almost every test already starts the batcher and awaits genesis (depending on genesis timing).

[tynes]

small nit would be ok without it

[ajsutton]

I think semgrep is failing when this gets updated with the latest changes from develop: https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/68416/workflows/7f921a39-67d0-4347-a696-ed7d359aa0f4/jobs/2831634

[tynes]

    op-batcher/batcher/driver.go
   ❯❯❱ dgryski.semgrep-go.timeafter.leaky-time-after
          Leaky use of time.After in for-select, see: https://groups.google.com/g/golang-
          nuts/c/cCdm0Ixwi9A/m/jMiJJScAEAAJ                                              
          Details: https://sg.run/dgrQ                                                   
                                                                                         
          310┆ for {
          311┆   cCtx, cancel := context.WithTimeout(ctx, l.Config.NetworkTimeout)
          312┆   syncStatus, err = rollupClient.SyncStatus(cCtx)
          313┆   cancel()
          314┆ 
          315┆   // Ensure that we have the sync status
          316┆   if err != nil {
          317┆           return eth.BlockID{}, eth.BlockID{}, fmt.Errorf("failed to get sync status: %w",
               err)                                                                                      
          318┆   }
          319┆ 
             [hid 17 additional lines, adjust with --max-lines-per-finding] 
                            
  BLOCKING CODE RULES FIRED:
    dgryski.semgrep-go.timeafter.leaky-time-after

[jsvisa]

I think semgrep is failing when this gets updated with the latest changes from develop: https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/68416/workflows/7f921a39-67d0-4347-a696-ed7d359aa0f4/jobs/2831634

thanks for the info, we did leaked the timer, now use timer.Reset to reuse the timer