-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Interop: E2E cross l2 inbox #12268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interop: E2E cross l2 inbox #12268
Conversation
8d4774e to
91fe966
Compare
|
Semgrep found 138
require() must include a reason string Ignore this finding from sol-style-require-reason.Semgrep found 2 Prefer Semgrep found 4
Javadoc-style comments are not allowed. Use |
e43a260 to
a98e033
Compare
a98e033 to
fe6ea01
Compare
|
Semgrep found 2 require() must include a reason string Ignore this finding from sol-style-require-reason.Semgrep found 1 Prefer Semgrep found 2
Malformed revert statement style. Ignore this finding from sol-style-malformed-revert.Semgrep found 1 Javadoc-style comments are not allowed. Use Semgrep found 13
"challenge period too large" Malformed require statement style. Ignore this finding from sol-style-malformed-require. |
48e7d78 to
d872f65
Compare
|
Semgrep found 2 No |
320d742 to
0cc2e9a
Compare
|
This PR is stale. I continued the integration of cross-l2-inbox here and added you as co-author. Sorry about that, but a lot changed since this PR was drafted: #12754 |
This PR:
CrossL2Inbox.ExecuteMessageThese expanded behaviors let us test interop in E2E, specifically allowing us to emit executing messages.
This PR isn't fully functional yet, as calling the function and awaiting the receipt creates a
context.deadline.exceeded. I also found similar behavior when calling theop-gethclientBlockByHash, so I think something is closing when not intended.Based on top of #12427