op-e2e/system/fjord: Fix check script test #12231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
force-pushed
the
seb/fix-fjord-check-script-test
branch
from
57280f4 to
3c26cc8
Compare
sebastianst
force-pushed
the
seb/fix-fjord-check-script-test
branch
from
3c26cc8 to
ded95cd
Compare
tynes
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the Fjord check script test by activating Fjord not at genesis, but a block later. This also makes more sense as check scripts are only run in the context of post-genesis fork activations.
Also changed the inner
op_e2e.InitParallel(t)call to a regulart.Parallel()call in the hope that this fixes missing failing tests. I believe only top-level tests should call the helperop_e2e.InitParallel(t).Additional context
Reported here: #12197 (comment)