op-deployer: Fix init bug #12230
Merged
op-deployer: Fix init bug #12230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mslipper
force-pushed
the
bugfix/deployer-init
branch
from
04cefd2 to
7758c33
Compare
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
- The array was being appended to, but it was already a fixed length. This cause an empty chain to be added during `init`. - The outdir will now be created if it does not exist and is not a file - Hardcodes the contract artifacts to a good URL
mslipper
force-pushed
the
bugfix/deployer-init
branch
from
7758c33 to
1e94cb8
Compare
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
- The array was being appended to, but it was already a fixed length. This cause an empty chain to be added during `init`. - The outdir will now be created if it does not exist and is not a file - Hardcodes the contract artifacts to a good URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The array was being appended to, but it was already a fixed length. This cause an empty chain to be added during
init.