op-e2e: Retrieve AllocType from System instead of env #12221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
requested review from
Inphi,
bitwiseguy and
pauldowman
and removed request for
a team
Contributor
|
Semgrep found 1 New code should use errors.Is with the appropriate error type Ignore this finding from os-error-is-not-exist. |
ajsutton
force-pushed
the
aj/use-system
branch
from
b40d9b9 to
4d45322
Compare
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…ism#12221) * op-e2e: Retrieve AllocType from System instead of env * Remove more uses of env. * op-e2e: Run mt-cannon as an allocType without needing special env vars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #12216 but tidies up the handling of AllocType in the dispute game helpers.