-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch step panic in Guard
#12202
catch step panic in Guard
#12202
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12202 +/- ##
===========================================
- Coverage 75.19% 74.97% -0.22%
===========================================
Files 49 49
Lines 3656 3656
===========================================
- Hits 2749 2741 -8
- Misses 734 743 +9
+ Partials 173 172 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
@zhiqiangxu Please rebase this on develop so CI checks can pass. |
Done in 76bc53f. |
/ci authorize 76bc53f |
@Inphi , looks like there's a random CI failure irrelevant to this PR.. |
@zhiqiangxu Could you please do another rebase on develop? The tests seem flaky and I've repeatedly re-ran the tests to no avail. Perhaps the flakes are fixed on develop. |
Done. |
/ci authorize 6458246 |
03b66de
It seems the
error
return value ofvm.Step
is always nil, the exceptional cases are handled by panic directly(e.g., HandleBranch/HandleJump/HandleRd).So what actually needs to be guarded is the panic.