MT Cannon: add cannon load/store opcodes tests #12196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12196 +/- ##
===========================================
- Coverage 75.19% 74.97% -0.22%
===========================================
Files 49 49
Lines 3656 3656
===========================================
- Hits 2749 2741 -8
- Misses 734 743 +9
+ Partials 173 172 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
mbaxter
approved these changes
Oct 1, 2024
Contributor
mbaxter
left a comment
mbaxter
left a comment
There was a problem hiding this comment.
Looks good! Just left a few quibbles.
Signed-off-by: Chen Kai <281165273grape@gmail.com>
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
* feat:add cannon load/store opcodes tests Signed-off-by: Chen Kai <281165273grape@gmail.com> * fix:code review suggestion Signed-off-by: Chen Kai <281165273grape@gmail.com> --------- Signed-off-by: Chen Kai <281165273grape@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add lb/lh/lw/lbu/lhu/lwl/lwr/sb/sh/swl/sw/swr tests
Tests
Additional context
Metadata