Skip to content

Conversation

@geoknee
Copy link
Contributor

@geoknee geoknee commented Sep 27, 2024

This helps formalise our management of data in the queue, which is important for #12120

Note that the ChannelQueue is not a good candidate for using this new data structure, since we do linear search and removal of arbitrary elements.

@geoknee geoknee requested review from a team as code owners September 27, 2024 17:01
@geoknee geoknee requested a review from bitwiseguy September 27, 2024 17:01
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Sep 30, 2024

Semgrep found 2 golang_fmt_errorf_no_params findings:

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

@geoknee geoknee marked this pull request as draft September 30, 2024 10:01
@geoknee geoknee marked this pull request as ready for review September 30, 2024 12:48
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Oct 2, 2024

Semgrep found 8 golang_fmt_errorf_no_params findings:

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

Semgrep found 3 dangerous-exec-command findings:

Detected non-static command inside Command. Audit the input to 'exec.Command'. If unverified user data can reach this call site, this is a code injection vulnerability. A malicious actor can inject a malicious script to execute arbitrary code.

Ignore this finding from dangerous-exec-command.

@sebastianst sebastianst enabled auto-merge October 2, 2024 17:32
@sebastianst sebastianst added this pull request to the merge queue Oct 2, 2024
Merged via the queue into develop with commit d1f6501 Oct 2, 2024
@sebastianst sebastianst deleted the gk/batcher-holocene-queue branch October 2, 2024 17:51
protolambda pushed a commit that referenced this pull request Oct 7, 2024
* op-service: add queue package

* batcher: use Queue type for blocks

* revert changes to errors.As/Is

* implement and use Peek operation

* queue: add unit tests

* add godoc

* add more test cases

permute expected / got

* ensure enqueue and prepend are noops when args is empty

* use queue.PeekN and queue.DequeueN

* typo

* queue: simplify method implementations

* revert to old dequeue impl
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
…12180)

* op-service: add queue package

* batcher: use Queue type for blocks

* revert changes to errors.As/Is

* implement and use Peek operation

* queue: add unit tests

* add godoc

* add more test cases

permute expected / got

* ensure enqueue and prepend are noops when args is empty

* use queue.PeekN and queue.DequeueN

* typo

* queue: simplify method implementations

* revert to old dequeue impl
@geoknee geoknee added the A-op-batcher Area: op-batcher label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-batcher Area: op-batcher

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants