fix(ct): correct input and return argument formatting #12131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardizes the input and return argument formatting everywhere.
smartcontracts
force-pushed
the
sc/ct-fix-inp-ret-args
branch
from
f6deb35 to
2fa8952
Compare
Contributor
Author
|
Slither is a false positive |
smartcontracts
requested review from
mds1
and removed request for
Inphi and
blmalone
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12131 +/- ##
===========================================
- Coverage 68.30% 68.11% -0.20%
===========================================
Files 54 54
Lines 4118 4118
===========================================
- Hits 2813 2805 -8
- Misses 1126 1135 +9
+ Partials 179 178 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
mds1
approved these changes
Sep 25, 2024
sebastianst
approved these changes
Sep 25, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…ism#12131) Standardizes the input and return argument formatting everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizes the input and return argument formatting everywhere.