cannon: Support the --version argument for multicannon #12101
Merged
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pick up the version from the release tag automatically.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12101 +/- ##
===========================================
- Coverage 68.32% 68.11% -0.22%
===========================================
Files 54 54
Lines 4117 4118 +1
===========================================
- Hits 2813 2805 -8
- Misses 1125 1135 +10
+ Partials 179 178 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sebastianst
approved these changes
Sep 25, 2024
Inphi
approved these changes
Sep 25, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…imism#12101) Pick up the version from the release tag automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support the
--versionargument for multicannon so that the cross-platform test works. It also now picks up the version from the git tag like all our other executables.