cannon: Build the cannon docker image and publish on cannon release tags #12100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
requested review from
Inphi and
sebastianst
and removed request for
sebastianst
Contributor
Author
|
Note: May need to adjust this once #12072 is merged to ensure the docker image contains the separate implementation versions, not just multicannon or we'll wind up playing Russian dolls... |
ajsutton
force-pushed
the
aj/cannon-docker
branch
from
2e95a09 to
d44eded
Compare
Contributor
Author
|
Copied the implementations over to the final docker image. Conveniently this means we should only ever need to pull one cannon docker image to get all the implementations we need since each release copies in all the embed versions multicannon supports, including the ones that were copied from a previous image so we can just grab them from there. |
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…ags (ethereum-optimism#12100) * cannon: Build the cannon docker image and publish on cannon release tags. * ci: Add docker builds as dependencies so they prevent merging if they fail. * cannon: Include specific implementation builds in final docker image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Actually publishing the cannon docker image allows it to be used as the source for legacy versions of cannon to provide backwards compatibility.