feat(sequencer): Origin Selector optimistically prefetches the next origin#12073
Closed
BrianBland wants to merge 3 commits intoethereum-optimism:developfrom
Closed
feat(sequencer): Origin Selector optimistically prefetches the next origin#12073BrianBland wants to merge 3 commits intoethereum-optimism:developfrom
BrianBland wants to merge 3 commits intoethereum-optimism:developfrom
Conversation
417064e to
7102d7e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12073 +/- ##
===========================================
- Coverage 79.10% 78.87% -0.24%
===========================================
Files 41 41
Lines 3437 3437
===========================================
- Hits 2719 2711 -8
- Misses 548 557 +9
+ Partials 170 169 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
7102d7e to
5f38c57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the Sequencer's L1 origin selector to locally cache the
currentOriginandnextOriginattributes and also optimistically prefetch thenextOriginin the background wheneverFindL1Originis called. This also forces a synchronous prefetch on eachForkchoiceUpdateEventin order to produce more deterministic behavior, but at the cost of sequencer performance when using a single-threaded event loop. (Addressed by #11100)In many cases, the existing L1 origin is "good enough" for building a new block from the sequencer's perspective, and it's better to fetch the next L1 origin in the background instead of spending precious time that could otherwise be used for building the next block. In these conditions, the
currentOriginwill be returned and fetching thenextOriginwill be scheduled in a new goroutine. Whenever thenextOriginis already available and valid, this is returned instead.Under specific circumstances, such as when a new L1 origin has not been found for a long period of time, the sequencer will actually need to review the
nextOriginand determine if this is valid (behind the next L2 block time). In these cases, theFindL1Origincall will wait for the background fetch to complete, and compare these potential origins immediately.This implementation uses a channel for notifying the
FindL1Origincontext of the fetch job's completion (by closing the channel). The channel is created within the publicFindL1Originmethod, and passed to a privatefindL1Origin, which is typically used in tests to provide a reasonable degree of deterministic concurrency control.Note: This changeset can also be simplified to only introduce event-based prefetching for the L1 Origin Selector (using
ForkchoiceUpdateEvent) if desiredTests
Added several new origin selector tests and added concurrency checks to the existing tests in order to ensure that this new prefetching behavior is safe under all conditions.
Metadata
Partially addresses #11960. In order to fully resolve this ticket, we may need to merge the origin selector and attributes builder, so that an origin is only selected if and only if it also has the relevant attributes already built or has all of the data needed to build attributes (L1 receipts).