Conversation
Contributor
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
blmalone
commented
Sep 20, 2024
blmalone
commented
Sep 20, 2024
blmalone
commented
Sep 20, 2024
blmalone
commented
Sep 20, 2024
Contributor
|
Semgrep found 10
No |
Contributor
|
Semgrep found 1 Named return arguments to functions must be appended with an underscore ( |
474d4e3 to
75bc772
Compare
blmalone
commented
Sep 23, 2024
mds1
reviewed
Sep 23, 2024
mds1
reviewed
Sep 23, 2024
mds1
reviewed
Sep 23, 2024
mds1
reviewed
Sep 23, 2024
mds1
reviewed
Sep 23, 2024
Contributor
|
This LGTM, just holding off on approving so we ensure #12064 is merged before this one
|
eb6838e to
29936ce
Compare
mds1
reviewed
Sep 24, 2024
mds1
reviewed
Sep 24, 2024
mds1
approved these changes
Sep 24, 2024
9a0d215 to
c131a31
Compare
mslipper
approved these changes
Sep 24, 2024
samlaf
pushed a commit
to samlaf/optimism
that referenced
this pull request
Nov 10, 2024
…12035) * forge install: superchain-registry v0.1.2 * fix: better clarity around when we're in a broadcast context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added functionality to either reuse previously deployed implementations of deploy new implementations based on the release string that's passed through to
DeployImplementations.s.sol.op-deployerpasses thestandard-versions.tomlstring though toDeployImplementations.s.solas input. A foundry cheatcode for reading toml is reimplemented in go to make this work.Follow up work is needed to make this a cleaner solution, which is outlined in this issue: #12067