Skip to content

feat: Implement release-based contract deployment#12035

Merged
blmalone merged 2 commits intodevelopfrom
09-20-feat_optionally_deploy_implementation_contracts_based_on_release_tag
Sep 24, 2024
Merged

feat: Implement release-based contract deployment#12035
blmalone merged 2 commits intodevelopfrom
09-20-feat_optionally_deploy_implementation_contracts_based_on_release_tag

Conversation

@blmalone
Copy link
Contributor

@blmalone blmalone commented Sep 20, 2024

Added functionality to either reuse previously deployed implementations of deploy new implementations based on the release string that's passed through to DeployImplementations.s.sol.

op-deployer passes the standard-versions.toml string though to DeployImplementations.s.sol as input. A foundry cheatcode for reading toml is reimplemented in go to make this work.

Follow up work is needed to make this a cleaner solution, which is outlined in this issue: #12067

@blmalone blmalone marked this pull request as ready for review September 20, 2024 20:01
@blmalone blmalone requested review from a team as code owners September 20, 2024 20:01
@blmalone blmalone requested a review from mbaxter September 20, 2024 20:01
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blmalone and the rest of your teammates on Graphite Graphite

@blmalone blmalone removed the request for review from mbaxter September 20, 2024 20:01
@blmalone blmalone requested a review from mds1 September 20, 2024 20:02
@blmalone blmalone self-assigned this Sep 20, 2024
@blmalone blmalone requested a review from a team as a code owner September 20, 2024 21:10
@blmalone blmalone requested review from protolambda and removed request for protolambda September 20, 2024 21:10
@blmalone blmalone requested a review from mslipper September 20, 2024 21:54
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Sep 21, 2024

Semgrep found 10 golang_fmt_errorf_no_params findings:

  • op-supervisor/supervisor/backend/db/safety_checkers_test.go
  • op-supervisor/supervisor/backend/db/db_test.go
  • op-chain-ops/deployer/state/intent.go
  • op-chain-ops/deployer/pipeline/superchain.go
  • op-chain-ops/deployer/pipeline/opchain.go
  • op-chain-ops/deployer/pipeline/l2genesis.go
  • op-chain-ops/deployer/pipeline/implementations.go
  • op-chain-ops/deployer/inspect/rollup.go
  • op-chain-ops/deployer/inspect/flags.go

No fmt.Errorf invocations without fmt arguments allowed

Ignore this finding from golang_fmt_errorf_no_params.

@blmalone blmalone requested a review from a team as a code owner September 23, 2024 16:15
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Sep 23, 2024

Semgrep found 1 sol-style-return-arg-fmt finding:

  • packages/contracts-bedrock/src/L1/OPStackManager.sol

Named return arguments to functions must be appended with an underscore (_)

Ignore this finding from sol-style-return-arg-fmt.

@blmalone blmalone force-pushed the 09-20-feat_optionally_deploy_implementation_contracts_based_on_release_tag branch from 474d4e3 to 75bc772 Compare September 23, 2024 20:44
@mds1
Copy link
Contributor

mds1 commented Sep 23, 2024

This LGTM, just holding off on approving so we ensure #12064 is merged before this one

Failing CI seems to be an out of order nonce issue when broadcasting? Looks like it was just a flaky test

@blmalone blmalone force-pushed the 09-20-feat_optionally_deploy_implementation_contracts_based_on_release_tag branch from eb6838e to 29936ce Compare September 24, 2024 16:02
@blmalone blmalone requested a review from mds1 September 24, 2024 16:06
@blmalone blmalone force-pushed the 09-20-feat_optionally_deploy_implementation_contracts_based_on_release_tag branch from 9a0d215 to c131a31 Compare September 24, 2024 17:11
@blmalone blmalone enabled auto-merge September 24, 2024 17:33
@blmalone blmalone added this pull request to the merge queue Sep 24, 2024
Merged via the queue into develop with commit 8b76931 Sep 24, 2024
@blmalone blmalone deleted the 09-20-feat_optionally_deploy_implementation_contracts_based_on_release_tag branch September 24, 2024 17:51
samlaf pushed a commit to samlaf/optimism that referenced this pull request Nov 10, 2024
…12035)

* forge install: superchain-registry

v0.1.2

* fix: better clarity around when we're in a broadcast context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants