Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove file I/O from deployment scripts #12015

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

blmalone
Copy link
Contributor

This pull request removes file I/O functionality from deployment scripts, simplifying the codebase and focusing on core deployment logic. Key changes include:

  1. Removed loadInputFile and writeOutputFile methods from various input and output contracts.
  2. Eliminated the run function that accepted file paths as arguments in deployment scripts.
  3. Removed related tests for file I/O operations.
  4. Updated comments to reflect the removal of file-based interactions.

These changes streamline the deployment process, making it more suitable for direct programmatic use in Solidity and Go environments. The update maintains the existing core deployment logic while removing the complexity associated with file-based configurations.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @blmalone and the rest of your teammates on Graphite Graphite

@blmalone blmalone marked this pull request as ready for review September 19, 2024 22:22
@blmalone blmalone requested a review from a team as a code owner September 19, 2024 22:22
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye file I/O, you will be missed 🫡

@blmalone blmalone added this pull request to the merge queue Sep 20, 2024
Merged via the queue into develop with commit af357f1 Sep 20, 2024
63 checks passed
@blmalone blmalone deleted the 09-19-fix_removing_all_file_i_o_features branch September 20, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants