cannon: Clean up fuzz test todos #12009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12009 +/- ##
===========================================
- Coverage 79.20% 78.87% -0.33%
===========================================
Files 41 41
Lines 3414 3437 +23
===========================================
+ Hits 2704 2711 +7
- Misses 541 557 +16
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Inphi
approved these changes
Sep 19, 2024
Yeah, that test is kind of gnarly, but at least now we're testing some more varied behavior. Before we were just processing random data, so we would mostly never process any hints because the hint length prefix was some huge random number. |
Merged
via the queue into
ethereum-optimism:develop
with commit Sep 19, 2024
29dd98b
60 checks passed
blmalone
pushed a commit
that referenced
this pull request
Sep 19, 2024
* cannon: Add memory assertions to FuzzStatePreimageRead * cannon: Rework hint write fuzz test to assert hint expectations * cannon: Update FuzzStatePreimageWrite to assert on expected preimageKey * cannon: Remove validation skipping logic from test util * cannon: Cleanup - simplify code * cannon: Cleanup - dedupe code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean-up some deferred todos from
fuzz_evm_common_test.go. Remove special cases that skip a few types of validation and add assertions for all fields.Also includes some small changes to test helpers:
Metadata
Fixes #11651