Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op-e2e): Channel timeout late submission test #11995

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

clabby
Copy link
Member

@clabby clabby commented Sep 19, 2024

Overview

Creates a test for opening a channel, timing said channel out, submitting the final channel frame after the channel has timed out, and then proving a block within the re-submitted channel.

Also fixes the initial channel timeout test. Since granite is active, we must use the channel timeout from the rollup config, as the test params don't actually update it.

@clabby clabby requested review from a team as code owners September 19, 2024 02:45
Copy link
Member Author

clabby commented Sep 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd say skip all the finalising L1 - its adding noise to the test and if anything makes it easier on the derivation pipeline which should be capable of following the unsafe head.

op-e2e/actions/proofs/channel_timeout_test.go Outdated Show resolved Hide resolved
@clabby clabby added this pull request to the merge queue Sep 19, 2024
Merged via the queue into develop with commit e2a19f4 Sep 19, 2024
62 checks passed
@clabby clabby deleted the cl/channel-timeout-resubmit branch September 19, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants