-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPSM: More assertions #11994
Merged
Merged
OPSM: More assertions #11994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mds1
commented
Sep 18, 2024
also sorts methods alphabetically for clarity
mds1
force-pushed
the
opsm/more-assertions
branch
from
September 18, 2024 23:02
5f90a96
to
f51a387
Compare
mds1
force-pushed
the
opsm/more-assertions
branch
from
September 18, 2024 23:26
70a5d3d
to
e874a0d
Compare
maurelian
reviewed
Sep 19, 2024
maurelian
reviewed
Sep 19, 2024
maurelian
reviewed
Sep 19, 2024
maurelian
reviewed
Sep 19, 2024
maurelian
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a bunch of comments, which should be considered but are non-blocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11943 to add the remaining assertions from
ChainAssertions
. It also adds a few additional ones for OPSM, MIPS, and the PreimageOracle